Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify Graph.asymmetry() docstring #546

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jGaboardi
Copy link
Member

Clarify Graph.asymmetry() docstring.

xref: #540, #543 (comment)

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lgtm

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #546 (7c942e4) into geographs (c6d8e2a) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           geographs    #546     +/-   ##
===========================================
+ Coverage       80.8%   80.9%   +0.1%     
===========================================
  Files            125     125             
  Lines          14351   14351             
===========================================
+ Hits           11595   11604      +9     
+ Misses          2756    2747      -9     
Files Changed Coverage Δ
libpysal/graph/base.py 97.9% <ø> (ø)

... and 1 file with indirect coverage changes

@jGaboardi jGaboardi merged commit e579820 into pysal:geographs Aug 8, 2023
9 checks passed
@jGaboardi jGaboardi deleted the graph_asymm_docstring branch August 8, 2023 18:09
@jGaboardi
Copy link
Member Author

As a follow up to this, will the upcoming Graph class have an asymmetries() property like that in W?

@martinfleis
Copy link
Member

That is up to a discussion. Not sure if it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants