-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: avoid most of the warnings coming from dev CI #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Great work.
Approved too soon... Seeing failures – |
Because the way pandas is deprecating the |
Codecov Report
@@ Coverage Diff @@
## main #591 +/- ##
=======================================
+ Coverage 84.0% 84.2% +0.2%
=======================================
Files 128 128
Lines 15053 15080 +27
=======================================
+ Hits 12642 12698 +56
+ Misses 2411 2382 -29
|
Some future-proofing, a lot of silencing. Got it down from 1200+ to 5, out of which 4 will be solved in upstream (apache/arrow#38374) and one seems to be coming from
scipy.sparse
internals, so there's not a lot we can do apart from silencing but I'd give it some time.Closes #582