Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint ./examples/* #607

Merged
merged 2 commits into from
Oct 25, 2023
Merged

lint ./examples/* #607

merged 2 commits into from
Oct 25, 2023

Conversation

jGaboardi
Copy link
Member

This PR lints and re-formats the ./examples/* directory. --> xref #597

@jGaboardi jGaboardi self-assigned this Oct 25, 2023
@jGaboardi jGaboardi mentioned this pull request Oct 25, 2023
Closed
25 tasks
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #607 (c9d8a4c) into main (6ae2575) will decrease coverage by 0.0%.
The diff coverage is 59.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #607     +/-   ##
=======================================
- Coverage   84.2%   84.2%   -0.0%     
=======================================
  Files        137     137             
  Lines      14781   14780      -1     
=======================================
- Hits       12445   12444      -1     
  Misses      2336    2336
Files Coverage Δ
libpysal/examples/tests/test_available.py 96.8% <100.0%> (ø)
libpysal/examples/builtin.py 89.7% <60.0%> (ø)
libpysal/examples/remotes.py 74.4% <57.1%> (ø)
libpysal/examples/base.py 60.4% <50.0%> (-0.2%) ⬇️

martinfleis
martinfleis reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on docstring formatting, otherwise looks great!

libpysal/examples/base.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi merged commit 92bc9d1 into pysal:main Oct 25, 2023
10 checks passed
@jGaboardi jGaboardi deleted the lint_examples branch October 25, 2023 17:26
This was referenced Oct 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @martinfleis