Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint graph/_*.py #618

Merged
merged 6 commits into from
Oct 31, 2023
Merged

lint graph/_*.py #618

merged 6 commits into from
Oct 31, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 31, 2023

xref #589

This PR:

  • formats and lints libpysal/graph/_*.py
  • rename _set_ops._Set_Mixin to _set_ops.SetOpsMixin

@martinfleis
Copy link
Member

I can add the remaining 2 files (_{contiguity, _kernel}.py) in here

include those.

What do we think about renaming _set_ops._Set_Mixin --> _set_ops._SetMixin? Or even something like _set_ops .SetOpsMixin to conform with naming conventions?

Whatever, this is fully private. Happy to stick to strict CamelCase if it lives in the private module anyway

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #618 (6710a60) into main (ed98cbd) will increase coverage by 0.0%.
The diff coverage is 85.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #618   +/-   ##
=====================================
  Coverage   84.4%   84.4%           
=====================================
  Files        139     139           
  Lines      14867   14865    -2     
=====================================
+ Hits       12541   12543    +2     
+ Misses      2326    2322    -4     
Files Coverage Δ
libpysal/graph/_contiguity.py 98.9% <100.0%> (ø)
libpysal/graph/_plotting.py 95.7% <100.0%> (ø)
libpysal/graph/_set_ops.py 94.7% <100.0%> (ø)
libpysal/graph/_spatial_lag.py 100.0% <100.0%> (ø)
libpysal/graph/_utils.py 88.9% <100.0%> (ø)
libpysal/graph/base.py 97.6% <100.0%> (ø)
libpysal/graph/_triangulation.py 97.2% <75.0%> (ø)
libpysal/graph/_parquet.py 84.0% <71.4%> (ø)
libpysal/graph/_kernel.py 88.1% <79.3%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@knaaptime
Copy link
Member

swap it james. I dont like ignoring pep8 anyway. i'll be psyched once we finally get rid of those underscores in esda

@jGaboardi jGaboardi changed the title lint graph/_*.py (part 1) lint graph/_*.py Oct 31, 2023
libpysal/graph/_kernel.py Outdated Show resolved Hide resolved
libpysal/graph/_parquet.py Outdated Show resolved Hide resolved
libpysal/graph/_plotting.py Outdated Show resolved Hide resolved
jGaboardi and others added 2 commits October 31, 2023 14:38
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more notes, sorry

libpysal/graph/_utils.py Show resolved Hide resolved
libpysal/graph/_utils.py Outdated Show resolved Hide resolved
@jGaboardi jGaboardi merged commit b491bbb into pysal:main Oct 31, 2023
9 of 10 checks passed
@jGaboardi jGaboardi deleted the lint_format_graph_2 branch October 31, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants