Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint & format io/iohandlers{p-s}.py #641

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

jGaboardi
Copy link
Member

xref #589

This PR:

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #641 (f2efae9) into main (f1d8227) will increase coverage by 0.0%.
The diff coverage is 76.7%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #641   +/-   ##
=====================================
  Coverage   83.9%   83.9%           
=====================================
  Files        139     139           
  Lines      14966   14958    -8     
=====================================
- Hits       12559   12555    -4     
+ Misses      2407    2403    -4     
Files Coverage Δ
libpysal/io/iohandlers/stata_txt.py 98.7% <100.0%> (ø)
libpysal/io/iohandlers/pyShpIO.py 72.7% <63.6%> (ø)
libpysal/io/iohandlers/pyDbfIO.py 79.0% <72.7%> (+1.0%) ⬆️

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few questionable changes in there.

libpysal/io/iohandlers/pyDbfIO.py Show resolved Hide resolved
libpysal/io/iohandlers/pyDbfIO.py Show resolved Hide resolved
libpysal/io/iohandlers/pyShpIO.py Show resolved Hide resolved
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James.

@jGaboardi jGaboardi merged commit dcc9403 into pysal:main Nov 11, 2023
10 checks passed
@jGaboardi jGaboardi deleted the lint_format_io_iohandlers_part_3 branch November 11, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants