final lint/format run through & update pre-commit #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.pre-commit
for forblack
andruff
ruff
, updatepyproject.toml
and pre-commit for linting #589To decide:
pyproject.toml
, I am more leaning towards the mindset of omitting[tool.ruff.ignore]
inpyproject.toml
altogether and handling 99.9% of cases within files themselves (everything in the PR passes that way). However, I know others may think this is too strict. So yay or nay for keeping[tool.ruff.ignore]
?Once the PR is reviewed and merged the last step in #589 will be to enable
pre-commit
on triggered GHA