Add timeout in request to handle off-line use cases in examples #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
approved these changes
Jun 8, 2024
libpysal/examples/remotes.py
Outdated
| @@ -643,7 +643,7 @@ def _remote_data(): | |||
|
|
|||
| url = "https://geodacenter.github.io/data-and-lab//" | |||
| try: | |||
| page = requests.get(url) | |||
| page = requests.get(url, timeout=10) | |||
There was a problem hiding this comment.
Curious if there is a specific reason for 10 seconds?
martinfleis
reviewed
Jun 10, 2024
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=======================================
- Coverage 85.0% 83.9% -1.1%
=======================================
Files 141 145 +4
Lines 15203 15567 +364
=======================================
+ Hits 12924 13056 +132
- Misses 2279 2511 +232
|
martinfleis
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#695