Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib to implement simport #729

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Use importlib to implement simport #729

merged 1 commit into from
Jun 27, 2024

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jun 26, 2024

  1. You have run tests on this submission locally using pytest on your changes. Continuous integration will be run on all PRs with GitHub Actions, but it is good practice to test changes locally prior to a making a PR.
  2. This pull request is directed to the pysal/master branch.
  3. This pull introduces new functionality covered by
    docstrings and
    unittests?
  4. [n/a] You have assigned a
    reviewer
    and added relevant labels
  5. The justification for this PR is:

It seems the previous exec/eval version doesn't work on Python 3.13.

It seems the previous exec/eval version doesn't work on Python 3.13.
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.1%. Comparing base (e82d1be) to head (9156c63).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #729     +/-   ##
=======================================
+ Coverage   83.9%   85.1%   +1.2%     
=======================================
  Files        145     145             
  Lines      15583   15585      +2     
=======================================
+ Hits       13077   13270    +193     
+ Misses      2506    2315    -191     
Files Coverage Δ
libpysal/common.py 71.9% <100.0%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jGaboardi jGaboardi merged commit 6f8925e into pysal:main Jun 27, 2024
11 checks passed
@QuLogic QuLogic deleted the py313 branch June 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants