Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: ignore spvcm, add osmnx to env, xfail stuff out of control in reverse dep testing #731

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

martinfleis
Copy link
Member

Minor update of the reverse dep testing. I'd like to get it green soon-ish.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.2%. Comparing base (e82d1be) to head (50a5144).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #731     +/-   ##
=======================================
+ Coverage   83.9%   85.2%   +1.3%     
=======================================
  Files        145     145             
  Lines      15583   15639     +56     
=======================================
+ Hits       13077   13323    +246     
+ Misses      2506    2316    -190     

see 4 files with indirect coverage changes

@martinfleis martinfleis changed the title CI: ignore spvcm, add osmnx to env in reverse dep testing CI: ignore spvcm, add osmnx to env, xfail stuff out of control in reverse dep testing Jun 26, 2024
@martinfleis
Copy link
Member Author

The testing is now green - https://github.com/pysal/libpysal/actions/runs/9685217826/job/26724801044

We should revise the xfail list once relevant packages get new releases.

@martinfleis martinfleis marked this pull request as ready for review June 26, 2024 19:28
@jGaboardi jGaboardi added github_actions Pull requests that update Github_actions code downstream labels Jun 26, 2024
@martinfleis martinfleis merged commit 889d85b into pysal:main Jun 26, 2024
11 checks passed
@martinfleis martinfleis deleted the rev_dep branch June 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants