Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nan handling in color array #229

Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix nan handling in color array #229

merged 3 commits into from
Sep 18, 2024

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Sep 10, 2024

this fixes a bug where nan observations were being dropped silently (the conversion from string to numpy array was broken). This implements a fix and updates the tests for cases that include nans (and colors)

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.6%. Comparing base (666accc) to head (3e4de03).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #229     +/-   ##
=======================================
+ Coverage   89.5%   89.6%   +0.1%     
=======================================
  Files          9       9             
  Lines       1127    1129      +2     
=======================================
+ Hits        1009    1012      +3     
+ Misses       118     117      -1     
Files with missing lines Coverage Δ
mapclassify/util.py 92.6% <100.0%> (+4.6%) ⬆️

@martinfleis
Copy link
Member

Can you write a test for this?

@knaaptime knaaptime added the bug label Sep 10, 2024
@knaaptime knaaptime merged commit e2613b5 into pysal:main Sep 18, 2024
20 checks passed
@knaaptime knaaptime deleted the colorarray branch September 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants