Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix ordering of closed loops in remove_false_nodes #645

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

martinfleis
Copy link
Member

This addition ensures that closed loops have their start/end point attached to the rest of the network.

@martinfleis martinfleis self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.0%. Comparing base (4037c70) to head (a97642d).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
momepy/preprocessing.py 57.7% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #645     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      38     +12     
  Lines       4328    6269   +1941     
=======================================
+ Hits        4214    6143   +1929     
- Misses       114     126     +12     
Files with missing lines Coverage Δ
momepy/tests/test_preprocess.py 100.0% <100.0%> (ø)
momepy/preprocessing.py 91.4% <57.7%> (-2.0%) ⬇️

@jGaboardi jGaboardi added the bug Something isn't working label Jul 17, 2024
@jGaboardi
Copy link
Member

jGaboardi commented Jul 17, 2024

@martinfleis Are the 2 failures in dev due to the ongoing Graph work there? If there are, I'll approve.

@martinfleis
Copy link
Member Author

That is gonna be the higher_order fix I merged in lib.

@martinfleis martinfleis merged commit 046e538 into pysal:main Jul 17, 2024
13 of 15 checks passed
@martinfleis martinfleis deleted the loops branch July 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants