Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: compatibility with numpy #147

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

martinfleis
Copy link
Member

This should fix compatibility with the latest numpy. This should be released ASAP as pointpats is now defunct in fresh environments (see our CI).

there's also a bit of auto-linting, sorry for that

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.9%. Comparing base (4ecafc6) to head (d9fa804).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pointpats/pointpattern.py 66.7% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #147     +/-   ##
=======================================
+ Coverage   69.7%   69.9%   +0.2%     
=======================================
  Files         12      12             
  Lines       1775    1785     +10     
=======================================
+ Hits        1237    1247     +10     
  Misses       538     538             
Files with missing lines Coverage Δ
pointpats/centrography.py 46.2% <ø> (ø)
pointpats/pointpattern.py 69.1% <66.7%> (ø)

@jGaboardi jGaboardi merged commit c49f7d2 into pysal:main Sep 9, 2024
10 checks passed
@martinfleis martinfleis deleted the np-compat branch September 9, 2024 15:28
@martinfleis martinfleis mentioned this pull request Sep 12, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants