make quadrat statistics accept a numpy array as argument #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only substantive change is this |
weikang9009
reviewed
Jul 17, 2020
| @@ -384,7 +387,7 @@ class QStatistic: | |||
| simulation based inference. Default is 0 | |||
| where no simulation based inference is | |||
| performed. | |||
|
|
|||
| Attributes | |||
| ---------- | |||
| pp : :class:`.PointPattern` | |||
There was a problem hiding this comment.
Looking good! Can you also change the docstrings and maybe add a small example for the addition?
There was a problem hiding this comment.
Sure, docstring is easy. Where would you like the example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
blackonquadrat_statistics.pyQStatisticto take a numpy array. When the input is a numpy array, the function converts it to a point pattern immediately.