Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][ENH] addressing shortest path extract #382

Merged
merged 11 commits into from
Jan 20, 2020
Merged

[WIP][ENH] addressing shortest path extract #382

merged 11 commits into from
Jan 20, 2020

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jan 17, 2020 •
edited
Loading

This PR addresses #380

  • spaghetti.Network.shortests_paths()
    • method
    • docstring
    • tests
    • example/notebook
  • spaghetti.element_as_gdf(new, routes=paths)
    • function
    • docstring
    • tests
    • example/notebook
  • rebuild docs

@jGaboardi jGaboardi self-assigned this Jan 17, 2020
@jGaboardi jGaboardi added this to the Release v1.4.1 milestone Jan 17, 2020
@coveralls
Copy link

coveralls commented Jan 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2158

  • 142 of 143 (99.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 98.208%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spaghetti/network.py 70 71 98.59%
Totals Coverage Status
Change from base Build 2145: 0.07%
Covered Lines: 1617
Relevant Lines: 1632
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2140

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.139%
Totals Coverage Status
Change from base Build 2139: 0.0%
Covered Lines: 1477
Relevant Lines: 1491
💛 - Coveralls

@jGaboardi
Copy link
Member Author

Also addressing #385

@jGaboardi jGaboardi mentioned this pull request Jan 20, 2020
Closed
5 tasks
@jGaboardi
Copy link
Member Author

tarball build failing again similar to that of #343

This was referenced Jan 20, 2020
Closed
Closed
@jGaboardi jGaboardi merged commit 703aa82 into pysal:master Jan 20, 2020
@jGaboardi jGaboardi deleted the routes branch January 20, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jGaboardi jGaboardi

Labels
enhancement WIP
Projects
None yet
Milestone
Release v1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @coveralls