Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formulation of KN-PMP omitted opening constraints #420

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Formulation of KN-PMP omitted opening constraints #420

merged 2 commits into from
Dec 10, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #419

@jGaboardi jGaboardi added bug Something isn't working locate labels Dec 9, 2023
@jGaboardi jGaboardi requested review from ljwolf and gegen07 December 9, 2023 22:19
@jGaboardi jGaboardi self-assigned this Dec 9, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2023 •
edited
Loading

Codecov Report

Merging #420 (6c89c4f) into main (8800d2f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #420   +/-   ##
=====================================
  Coverage   77.7%   77.7%           
=====================================
  Files         27      27           
  Lines       2634    2638    +4     
=====================================
+ Hits        2046    2050    +4     
  Misses       588     588
Files Coverage Δ
spopt/locate/base.py 94.4% <100.0%> (+0.1%) ⬆️
spopt/locate/p_median.py 97.2% <100.0%> (+<0.1%) ⬆️

@jGaboardi jGaboardi mentioned this pull request Dec 10, 2023
Closed
25 tasks
@ljwolf
Copy link
Member

ljwolf commented Dec 10, 2023

This looks good to me! It appears that without the opening constraints, clients weren't getting totally assigned.

@jGaboardi
Copy link
Member Author

This looks good to me! It appears that without the opening constraints, clients weren't getting totally assigned.

Yep, and being assigned to closed facilities.

@ljwolf ljwolf merged commit a914f21 into pysal:main Dec 10, 2023
10 checks passed
@jGaboardi jGaboardi deleted the knpmp_opening_constraint_bug branch December 10, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljwolf ljwolf Awaiting requested review from ljwolf

@gegen07 gegen07 Awaiting requested review from gegen07

Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working locate needs attention priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no opening constraints in $k$-nearest $p$-median
2 participants
@jGaboardi @ljwolf