Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units #164

Merged
merged 8 commits into from
Jul 5, 2022
Merged

units #164

merged 8 commits into from
Jul 5, 2022

Conversation

knaaptime
Copy link
Member

  • fix: addressing h3fy not completely filling polygon #146 h3fy not filling completely
  • bug: set clipper to source as default
  • refactor: do not expose buffer distance
  • refactor: use h3 api for radius
  • draft unit check
  • small reorg for clarity
  • wording
  • move concat outside for loop in h3fy

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #164 (594fb38) into master (66f3825) will decrease coverage by 0.05%.
The diff coverage is 44.00%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   74.24%   74.18%   -0.06%     
==========================================
  Files          20       20              
  Lines        1029     1046      +17     
==========================================
+ Hits          764      776      +12     
- Misses        265      270       +5     
Impacted Files Coverage Δ
tobler/util/util.py 75.00% <44.00%> (-16.53%) ⬇️
tobler/_version.py 40.65% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f3825...594fb38. Read the comment docs.

@knaaptime knaaptime merged commit d245ec1 into pysal:master Jul 5, 2022
@knaaptime
Copy link
Member Author

resolves #163 and #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants