Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return dfs #40

Merged
merged 27 commits into from
Jan 2, 2020
Merged

return dfs #40

merged 27 commits into from
Jan 2, 2020

Conversation

knaaptime
Copy link
Member

this enables a more consistent API by ensuring that the interpolation functions all return geodataframes with the target geometry

Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning a gdf is a nice enhancement.

@renanxcortes
Copy link
Collaborator

Agreed that this makes more sense

@renanxcortes
Copy link
Collaborator

The gdf was adding a bug in the values?

@knaaptime
Copy link
Member Author

instead of returning the full target df with interpolated values as an additional column, this will return a smaller df with only the interpolated variable and geometry

@knaaptime
Copy link
Member Author

tests are passing locally but having trouble locating the raster data on quilt

@knaaptime knaaptime merged commit 537995b into pysal:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants