Instrument CI to build minified python

pyscript · Sep 3, 2024 · b1958d0 · b1958d0
1 parent c791c74
commit b1958d0
Show file tree

Hide file tree

Showing 11 changed files with 133 additions and 106 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -21,7 +21,12 @@ jobs:
       with:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
+    - run: python -m venv env
+    - run: source env/bin/activate
+    - run: pip install --upgrade pip
+    - run: pip install --ignore-requires-python python-minifier
+    - run: pip install setuptools
     - run: npm ci
-    - run: npx playwright install
+    - run: npx playwright install chromium
     - run: npm run build
     - run: npm run test
diff --git a/README.md b/README.md
@@ -31,6 +31,9 @@ This project requires some automatic artifact creation to:
 Accordingly, to build latest project:
 
 ```sh
+# activate once the Python env (to use pyminify)
+. env.sh # or source env.sh
+
 # create all artifacts needed to test core
 npm run build
 

diff --git a/docs/index.js b/docs/index.js
diff --git a/docs/index.js.map b/docs/index.js.map
diff --git a/docs/zip-BIfA-Q-T.js.map b/docs/zip-BIfA-Q-T.js.map
diff --git a/docs/zip-BIfA-Q-T.js → docs/zip-DrwYHuF9.js b/docs/zip-BIfA-Q-T.js → docs/zip-DrwYHuF9.js
diff --git a/docs/zip-DrwYHuF9.js.map b/docs/zip-DrwYHuF9.js.map
diff --git a/env.sh b/env.sh
@@ -0,0 +1,12 @@
+#!/usr/bin/env sh
+
+# to use this env type either:
+# . env.sh
+# or
+# source env.sh
+
+python -m venv env
+source env/bin/activate
+pip install --upgrade pip
+pip install --ignore-requires-python python-minifier
+pip install setuptools
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,12 +42,12 @@
         "@playwright/test": "^1.46.1",
         "@rollup/plugin-node-resolve": "^15.2.3",
         "@rollup/plugin-terser": "^0.4.4",
-        "@zip.js/zip.js": "^2.7.51",
+        "@zip.js/zip.js": "^2.7.52",
         "c8": "^10.1.2",
         "chokidar": "^3.6.0",
         "eslint": "^9.9.1",
         "linkedom": "^0.18.4",
-        "rollup": "^4.21.1",
+        "rollup": "^4.21.2",
         "static-handler": "^0.4.3",
         "typescript": "^5.5.4"
     },
@@ -86,6 +86,6 @@
         "to-json-callback": "^0.1.1"
     },
     "worker": {
-        "blob": "sha256-QDmhtpGRALCZn/gNlUmUSRUiiNDmiCk9Pn61k6Addho="
+        "blob": "sha256-n5bp7XbiMOC5xSM8r1BjWIl0efV5DHH41AoMDzRWNdg="
     }
 }
diff --git a/rollup/build_python.cjs b/rollup/build_python.cjs
@@ -1,17 +1,24 @@
 // ⚠️ This file creates Python modules as JS TextEncoder().encode results
 
 const { join, resolve } = require('node:path');
-const { readdirSync, readFileSync, writeFileSync } = require('node:fs');
+const { readdirSync, writeFileSync } = require('node:fs');
+const { spawnSync } = require("node:child_process");
 
 const PYTHON_DIR = resolve(join(__dirname, '..', 'python'));
 const PYTHON_JS_DIR = resolve(join(__dirname, '..', 'esm', 'python'));
 
 const { stringify } = JSON;
 
 for (const file of readdirSync(PYTHON_DIR)) {
-    const python = stringify(
-        readFileSync(join(PYTHON_DIR, file)).toString()
-    );
+    const full = join(PYTHON_DIR, file);
+    const {
+        output: [error, result],
+    } = spawnSync("pyminify", [
+        "--remove-literal-statements",
+        full,
+    ]);
+    if (error) process.exit(1);
+    const python = stringify(result.toString());
     writeFileSync(
         join(PYTHON_JS_DIR, file.replace(/\.py$/, '.js')),
         `// ⚠️ DO NOT MODIFY - SOURCE FILE: "../../python/${file}"