Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some benchmark tests #37

Open
goodboy opened this issue Nov 18, 2016 · 2 comments
Open

Add some benchmark tests #37

goodboy opened this issue Nov 18, 2016 · 2 comments
Assignees
@goodboy
Labels
enhancement
Milestone
1.0

Comments

@goodboy
Copy link
Contributor

goodboy commented Nov 18, 2016

There's been some discussion (#15, #23) surrounding performance mostly as it pertains to the _Multicall.execute() loop.

I propose we add some tests which use pytest-benchmark or something similar to audit changes we make to critical code paths. This encourages being objective about future changes.
@goodboy goodboy mentioned this issue Dec 22, 2016
Closed
@goodboy goodboy mentioned this issue Feb 13, 2017
Open
@goodboy goodboy mentioned this issue Feb 24, 2017
Merged
@goodboy
Copy link
Contributor Author

goodboy commented Feb 24, 2017

Some other options to investigate:

@goodboy goodboy self-assigned this Apr 22, 2017
@goodboy goodboy added question and removed question labels Apr 22, 2017
goodboy pushed a commit that referenced this issue Jul 5, 2017
Add a baseline set of _MultiCall performance tests
d1f7d43 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 5, 2017
Add a baseline set of _MultiCall performance tests
d7ade7b 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 5, 2017
Add a baseline set of _MultiCall performance tests
c64cede 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 5, 2017
Add a baseline set of _MultiCall performance tests
4a2f399 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 5, 2017
Add a baseline set of _MultiCall performance tests
d8d6fdd 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 7, 2017
Add a baseline set of _MultiCall performance tests
62aacce 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
goodboy pushed a commit that referenced this issue Jul 7, 2017
Add a baseline set of _MultiCall performance tests
6babb6e 
This begins an effort to incorporate run-time speed tests using
`pytest-benchmark`. This initial test set audits the `_MultiCall`
loop with hookimpls, hookwrappers and the combination of both.
The intention is to eventually have a reliable set of tests which
enable making core component modifications without disrupting
performance as per #37.
@goodboy
Copy link
Contributor Author

goodboy commented Nov 9, 2018

There was recently a post on the pytest mailing list about a new alternative bench-marking system as well.

@goodboy goodboy added this to the 1.0 milestone Nov 9, 2018
@goodboy goodboy mentioned this issue Jun 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodboy goodboy

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@goodboy