-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to new style classes (object inheritance) - Issue #44 #46
Moving to new style classes (object inheritance) - Issue #44 #46
Conversation
Not at all, we have AppVeyor and Travis to test across all interpreters and configurations required. Thanks again! |
Is there any particular reason to move to new style classes? I typically try to use a subset of python such that it doesn't matter if a class derives from object. In fact i rarely use inheritance anyway :) |
This has been discussed in pytest-dev/pytest#2147, old-style classes introduce subtle differences that, granted, are hard to come by, but since it is simple to make it consistent across all versions we decided to just make them all new-style explicitly. |
@hpk42 @nicoddemus it's an interesting point too because in py3 old-style don't exist any more and the syntax is equivalent. |
oki. could you directly commit a changelog entry? |
oh yey and now I have to rebase everything lolz |
Adding to all classes inheritance from
object
class.All test green, excepts for Interpreters:
as I don't have them.
Hope it isn't an issue :)