Raise explicit error when impl called with pos args #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
requested changes
Aug 24, 2017
pluggy/__init__.py
Outdated
| def __call__(self, *args, **kwargs): | ||
| if args: | ||
| raise TypeError( | ||
| "hookimpl takes keyword arguments only".format(self.name) |
There was a problem hiding this comment.
that message is incorrect and cant hope to be formatted that way
i propose "hook calling supports only keyword arguments" as sole message
There was a problem hiding this comment.
Haha yeah.. I changed it 3 times so I'm not surprised.
Thanks for catching / I'll fix it.
There was a problem hiding this comment.
@RonnyPfannschmidt I just updated the existing test to check for the message.
Hopefully that's cool :)
|
there also should be an accompanying test |
nicoddemus
requested changes
Aug 24, 2017
There was a problem hiding this comment.
Thanks @tgoodlet!
As @RonnyPfannschmidt mentioned, please fix the message and add a test for it.
goodboy
force-pushed
the
comprehensible_hook_call_error
branch
from
ce2104b to
e2fa34b
Compare
Raise an explicit TypeError to alert the user that they are calling a hookimpl incorrectly with positional args; keyword args are allowed only. Add a test too. Fixes pytest-dev#53
goodboy
force-pushed
the
comprehensible_hook_call_error
branch
from
e2fa34b to
7748ba0
Compare
RonnyPfannschmidt
approved these changes
Aug 24, 2017
|
well done, thanks |
This was referenced Sep 6, 2017
This was referenced Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an explicit TypeError to alert the user that they are calling
a hookimpl incorrectly with positional args; keyword args are allowed
only.
Fixes #53