Support for Pytest 8.0 #737
Comments
|
Thanks. Unfortunately, pytest-asyncio doesn't properly limit the maximum pytest version. Pytest 8 introduces changes to the collection phase. Since it's a bit more effort for pytest-asyncio to accommodate those, I plan to temporarily exclude pytest>=8 from the compatible versions in a (post?) release. This doesn't resolve the issue, but it will prevent users from installing incompatible versions of pytest and pytest-asyncio. |
|
Understood, thank you! |
Pytest 8 made some changes to its test collection and pytest-asyncio currently isn't compatible with those changes. see pytest-dev#737 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Pytest 8 made some changes to its test collection and pytest-asyncio currently isn't compatible with those changes. see #737 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
|
pytest-asyncio v0.23.4a0 adds a maximum pytest version (pytest<8) to What's still left is to add actual support for pytest 8. |
|
Confirmed, thank you! https://github.com/ipython/ipykernel/actions/runs/7468436406/job/20323873110 |
|
@seifertm Can we please release an hofix? |
* added URL encoding for Docker Container Pull action * added two logs with `info` level for PullImage action * removed "optional API Scope" support * added AppAPI options toggles in Admin settings * added RestartPolicy option to created containers CI fails unrelated: pytest-dev/pytest-asyncio#737 --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com> Signed-off-by: Nextcloud bot <bot@nextcloud.com> Co-authored-by: Andrey Borysenko <andrey18106x@gmail.com> Co-authored-by: Nextcloud bot <bot@nextcloud.com> Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
pytest-asyncio doens't support pytest 8.0 yet: pytest-dev/pytest-asyncio#737 ticket to unpin dependeny: https://app.zenhub.com/workspaces/core-5a7c152b04a1652024289b7b/issues/gh/inmanta/inmanta-dev-dependencies/372
|
@analog-cbarber I saw that you already opened conda-forge/pytest-asyncio-feedstock#41 and it looks your issue has been resolved already. The feedstock is the correct place to report these kind of issues. I'm happy to help from the pytest-asyncio side, but none of the pytest-asyncio developers maintain the conda feedstock. |
Probably a good idea for one of the pytest-asyncio maintainers to sign on to maintain the conda feedstock so you don't get surprised by this kind of thing. It usually is not that much work. |
|
Apparently, the compatibility issues weren't as big in v0.23.4 as they were initially in the v0.23 releases. Thanks to the investigation by @mgorny and the subsequent PR submitted by @akeeman there's now a pre-release of pytest-asyncio with pytest 8 support. Version v0.23.5a0 does not contain code changes compared to v0.23.4, apart from fixes to the type annotations. Unless there are any unexpected issues, I'll tag a proper patch release by the end of the week. |
|
There were no reports related to issues of pytest-asyncio-0.23.5a0 and pytest 8. There area lot of people wanting to upgrade and there were no significant changes required for pytest 8 support. Therefore, I tagged v0.23.5. Thanks! |
|
Thanks! For the record, Gentoo's been patching the pytest-8 support in since 2024-02-06, and we've had no issues reported so far. |
Upstream issue was closed pytest-dev/pytest-asyncio#737 Signed-off-by: Joe Groocock <me@frebib.net>
pytest 8.0.0rc1 was released today, and we're seeing a startup failure with
pytest-asyncio:https://github.com/jupyter/jupyter_events/actions/runs/7386335973/job/20092726210
The text was updated successfully, but these errors were encountered: