Make sure InvalidVarException.fail is reset #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
force-pushed
the
fix_template_string_if_invalid_marker
branch
4 times, most recently
from
c13d7da to
bed7b43
Compare
bluetech
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Good catch @xavfernandez, I'm surprised no one had noticed this bug before.
I left a suggestion for simplifying the test.
Also, scrolling up a bit I see that _fail_for_invalid_template_variable has a similar issue, although it's less consequential since it's a session fixture. But it would be good to fix it as well.
tests/test_environment.py
Outdated
| def test_invalid_template_variable_marker_cleanup(django_testdir) -> None: | ||
| django_testdir.create_app_file( | ||
| """ | ||
| from django.urls import path |
There was a problem hiding this comment.
I think it will be easier to have the tests render the template directly using e.g. render_to_string instead of setting up views and requests and everything.
after a test using ignore_template_errors marker
xavfernandez
force-pushed
the
fix_template_string_if_invalid_marker
branch
from
bed7b43 to
787ceef
Compare
|
I also added cleanup to |
xavfernandez
force-pushed
the
fix_template_string_if_invalid_marker
branch
from
c9c29aa to
e71523a
Compare
xavfernandez
force-pushed
the
fix_template_string_if_invalid_marker
branch
from
e71523a to
86a93e7
Compare
xavfernandez
force-pushed
the
fix_template_string_if_invalid_marker
branch
from
714dd8f to
e9db1b7
Compare
xavfernandez
added a commit
to gip-inclusion/les-emplois
that referenced
this pull request
Nov 6, 2023
pytest-dev/pytest-django#1076 has been merged & released (in 4.6.0).
github-merge-queue bot
pushed a commit
to gip-inclusion/les-emplois
that referenced
this pull request
Nov 6, 2023
pytest-dev/pytest-django#1076 has been merged & released (in 4.6.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after a test using ignore_template_errors marker.
Otherwise, the first test set
failtoFalse, never to be changed again.