-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resetall() arguments #214
Conversation
Thanks a lot for the PR, appreciate it! The two keyword only arguments were added in Python 3.6 however, so it is breaking the 3.5 builds. I see two options:
Which one do you prefer? I don't see many reasons to keep supporting Python 3.5 given it has reached EOL and pytest 6.2 won't support it anymore either, but it is not something I plan to tackle in the next few weeks. |
Hi! Tanks for the feedback! Indeed I didn't notice the issue with Python 3.5. I usually don't like implementing functionality conditional on runtime versions unless absolutely necessary, so my first impulse would be to wait until support of 3.5 is dropped, especially if it's just around the corner. There are easy workarounds for this functionality in the meantime. What do you think? |
I also prefer to avoid them if possible. So let's wait then. I will update the title to reflect this, and then I will pick it up once support for 3.5 is dropped. 👍 Thanks again! |
Time to drop Python 3.5. 🎉 |
Thanks again for the PR! |
Adding standard
unittest.reset_mock()
's arguments toMockerFixture.resetall()
. It seems like a small fix, please tell me if I'm missing something!Closes #213