Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "mock.sentinel" to the "mocker" fixture for convenience. #56

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

kjwilcox
Copy link
Contributor

@kjwilcox kjwilcox commented Aug 2, 2016

Given that there is already some precedence for this sort of thing, it would be very convenient to be able to access mock.sentinel off of the mocker fixture.

I added this, updated the docs, updated the changelog, and added a test case (just adding a parameter to an existing parameterized test).

Please let me know whether or not this is a change you like, and if yes, if there's anything more I need to do to have this PR accepted.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7e1f7d5 on kjwilcox:master into 8f67a4f on pytest-dev:master.

@nicoddemus
Copy link
Member

That's perfect, thanks a lot! 😁

@nicoddemus nicoddemus merged commit f349582 into pytest-dev:master Aug 2, 2016
@kjwilcox
Copy link
Contributor Author

kjwilcox commented Aug 2, 2016

Thanks for the super quick response!

Any idea when 1.2 might see a release?

@nicoddemus
Copy link
Member

Just pushed 1.2 to PyPI. 😁 👍

@kjwilcox
Copy link
Contributor Author

kjwilcox commented Aug 2, 2016

Excellent, thank you!

@nicoddemus
Copy link
Member

Thanks again for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants