Update tests to work with pytest 3 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update tox.ini to run them.
|
Thanks! I'm surprised, the tests should be working. I will take a closer look on monday. |
|
Thanks for the PR. The tests are failing due to an unrelated issue related to how assertion reinterpretation was removed in pytest 3.0 and rewriting doesn't quite working automatically in development mode for plugins. I opened pytest-dev/pytest#1934 to discuss it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update tox.ini to run them.
This is not complete as 2 tests are still failing. I don't grasp exactly why, but I suspect we get a regular
AssertionError()because pytest didn't replace theassertat this point by its own one.Related to #61.