Add support for pytest-xdist #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +71,11 @@ def pytest_runtest_protocol(item, nextitem): | |||
| # first item if necessary | |||
| check_options(item.session.config) | |||
|
|
|||
| parallel = hasattr(item.config, 'slaveinput') | |||
There was a problem hiding this comment.
might want to use getattr here to avoid BaseException shallowing
nicoddemus
reviewed
Aug 18, 2017
pytest_rerunfailures.py
Outdated
| @@ -69,6 +71,11 @@ def pytest_runtest_protocol(item, nextitem): | |||
| # first item if necessary | |||
| check_options(item.session.config) | |||
|
|
|||
| parallel = hasattr(item.config, 'slaveinput') | |||
| plugins = [p[1] for p in item.config.pluginmanager.list_plugin_distinfo()] | |||
| xdist = next((LooseVersion(p.version) for p in plugins if | |||
There was a problem hiding this comment.
Might be better to write this as a function:
def works_with_current_xdist():
"""<explain details here>
"""
try:
d = pkg_resources.get_distribution('pytest-xdist')
return d.parsed_version >= pkg_resources.parse_version('1.20')
except pkg_resources.DistributionNotFound:
return NoneAnd then later use it as:
if not parallel or works_with_current_xdist():
|
Currently, the README mentions the limitations with pytest-xdist. Are there still some limitations left, or is all fine now? In both cases it would be good to adjust the README. |
|
@sallner I've updated the README by removing the note about the reruns not being reflected in the output when using pytest-xdist. |
davehunt
force-pushed
the
xdist-support
branch
from
d0a25db to
f61f658
Compare
|
@davehunt thanks for clarifying the readme |
|
@RonnyPfannschmidt @davehunt @nicoddemus I just carved out a new release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @nicoddemus' fix in pytest-dev/pytest-xdist#218 we can now log reruns when using pytest-xdist. If users have an older version of pytest-xdist then they'll see the same behaviour as before, but as soon as they upgrade they'll get the additional log entries.