Fix auto screenshots for session browser with latest pytest #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_fixture_values and _funcargs properties, the internal API for FixtureRequest object, are no longer available in latest versions of pytest. It appears fixturenames property and getfixturevalue() method can be used for the purpose of retrieving all session_browser fixture instances. According to changelog, both are available on pytest 3.0.0 and up. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
|
I ran into a trouble with getfixturevalues() so I am instead using: fixture_def = request._fixture_defs.get(name)
if not fixture_def or not fixture_def.cached_result:
continue
value = fixture_def.cached_result[0] |
jvalleroy
pushed a commit
to freedombox/FreedomBox
that referenced
this pull request
Jan 22, 2022
pytest_splinter has an issue with creating screenshots when using session_browser instead of a browser fixture. Implement a workaround. See: pytest-dev/pytest-splinter#157 Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
mpasternak
approved these changes
Aug 7, 2022
|
Hi. I reverted this, because this does not work with the recent CI - at all. Also, I understand this was a problem with pytest 5. We're now on pytest 7 and there seems to be no problem. In case you disagree, please re-submit this PR with the recent codebase. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_fixture_values and _funcargs properties, the internal API for FixtureRequest
object, are no longer available in latest versions of pytest. It appears
fixturenames property and getfixturevalue() method can be used for the purpose
of retrieving all session_browser fixture instances. According to changelog,
both are available on pytest 3.0.0 and up.
Signed-off-by: Sunil Mohan Adapa sunil@medhas.org