Add Splinter driver kwargs Chrome example override #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpasternak
reviewed
Aug 8, 2022
| @@ -147,6 +147,24 @@ Fixtures | |||
| """ | |||
| return {"service_log_path": Path("/log/directory/geckodriver.log")} | |||
|
|
|||
There was a problem hiding this comment.
Could you please add just a single line of text describing, what this code does, please? As in "The snippet below configures Chrome to ignore certificate errors and sets a specific window size". After that, I'm merging. Thanks.
There was a problem hiding this comment.
... also, if we only change docs, I'd love to see "[ci skip]" in the commit message, so CI won't get triggered. Like described here: https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs . Thanks!
mpasternak
requested changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.