Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of unnecessary dependency on py #185

Merged
merged 1 commit into from
Jul 16, 2017

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 14, 2017

pytest-xdist depends on pytest>=3.
pytest 3.0.0 requires py>=1.4.29
and latest pytest requires py>=1.4.33.
Thus it is unnecessary for pytest-xdist to include
a requirement on py>=1.4.22

Fixes #105


Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • Add a news file into the changelog folder, following these guidelines:

    • Name it $issue_id.$type for example 588.bug

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

`pytest-xdist` depends on `pytest>=3`.
`pytest 3.0.0` requires `py>=1.4.29`
and latest pytest requires `py>=1.4.33`.
Thus it is unnecessary for pytest-xdist to include
a requirement on `py>=1.4.22`

Fixes pytest-dev#105
@jayvdb
Copy link
Contributor Author

jayvdb commented Jul 14, 2017

Sorry if my changelog/foo entry is not correct. I am very happy to amend the commit to comply with whatever voodoo you are using. (and I think the PR template should explain what tool (towncrier?) is being used, so that the intelligent submitter can verify their changelog entry is correct).

@RonnyPfannschmidt RonnyPfannschmidt merged commit d2d5ae9 into pytest-dev:master Jul 16, 2017
@RonnyPfannschmidt
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement py>=1.4.22 is too low
2 participants