Stop looping if all workers have died

[timj]

If the workers are crashing and the restart limit has been met, we need to stop listening for events and trigger an internal error. This is related to #45

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• Make sure to include reasonable tests for your change if necessary

• We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

  • Name it $issue_id.$type for example 588.bugfix;

  • If you don't have an issue_id change it to the PR id after creating it

  • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

  • Make sure to use full sentences with correct case and punctuation, for example:

    Fix issue with non-ascii contents in doctest text files.
    

[timj]

Do you have tests that test failure conditions? I'll be happy to add a test if I get some examples for how to test if pytest has exited with bad status.

[RonnyPfannschmidt]

i propose something more along the lines of unexpectedly no active workers available so people can understand the error more easyly

[timj]

Fixed.

[timj]

I'm not entirely sure why one test failed this time. It passed before and I only changed the error message. Does this happen often?

[nicoddemus]

I triggered the build again and it has passed, seemed like a fluke.

@timj about the test, can you reproduce the problem into an isolated test file that can be run normally using pytest? If so, we can add an integration test in acceptance_test that uses testdir to do a black box test using your test file and check its output for the expected behavior.

[timj]

I have a test file that crashes. I'll see if I can add that.

[nicoddemus]

Hmm just managed a simple test which reproduces it:

import os
os._exit(1)

This hangs for me on master and raises the appropriate error on your fork. 👍

[timj]

I've added that test.

[nicoddemus]

Awesome, thanks!

[RonnyPfannschmidt]

good work, thanks 👍

[nicoddemus]

Let's release 1.20.1 after #233 gets merged.