Fix incompatibility error with --pdb despite using -n0
#938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atugushev Can you rebase? @pytest-dev Can we get tests allowed to run? |
nicoddemus
force-pushed
the
incompatible-pdb-n0-937
branch
from
7c72808
to
88decdb
Compare
|
Rebased. GitHub does not always run the GH actions for first time contributors, IIRC there were people opening random PRs which would use the actions for mining... 👀 |
nicoddemus
reviewed
Feb 14, 2024
| ) | ||
| check_options(config) | ||
| assert config.option.dist == "no" | ||
| assert config.option.tx == [] |
There was a problem hiding this comment.
Don't we want to also test passing -n0 and --pdb explicitly?
There was a problem hiding this comment.
Surely we do, thanks! Addressed in 0de6180.
|
@nicoddemus Thank you! |
atugushev
changed the title
—pdb despite using -n0--pdb despite using -n0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937.