Merge pull request #2226 from nicoddemus/raise-stop-iteration

Replace 'raise StopIteration' usages in the code by 'return's in accordance to PEP-479
pytest-dev · Feb 1, 2017 · da5a3db · da5a3db
2 parents 0931fe2 + e1c5314
commit da5a3db
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,14 +1,21 @@
 3.0.7 (unreleased)
-=======================
+==================
 
 *
 
+* Replace ``raise StopIteration`` usages in the code by simple ``returns`` to finish generators, in accordance to `PEP-479`_ (`#2160`_).
+  Thanks `@tgoodlet`_ for the report and `@nicoddemus`_ for the PR.
+
 *
 
 *
 
 *
 
+.. _#2160: https://github.com/pytest-dev/pytest/issues/2160
+
+.. _PEP-479: https://www.python.org/dev/peps/pep-0479/
+
 
 3.0.6 (2017-01-22)
 ==================

diff --git a/_pytest/python.py b/_pytest/python.py
@@ -174,7 +174,7 @@ def pytest_pycollect_makeitem(collector, name, obj):
     outcome = yield
     res = outcome.get_result()
     if res is not None:
-        raise StopIteration
+        return
     # nothing was collected elsewhere, let's do it here
     if isclass(obj):
         if collector.istestclass(obj, name):