Suggestion: KeybaordInterrupt pdb #3299
Comments
pytestbot
added
platform: mac
nicoddemus
added
plugin: debugging
|
I could do this. @nicoddemus sounds reasonable as described? How concerned are we about feature bloat? Is a legitimate use case reason enough to add a feature, or must it also be a reasonably common use case? |
|
Thanks for the offer @brianmaissy, IMHO this sounds useful, I have needed something like this a few times in the past as well. I think adding a new flag seems harmless, but I wonder how the implementation will look like. I would say give it a go and we can discuss this over the PR. |
|
My "Hacky" implementation simply changed the `KeyboardInterrupt` handler in
said place from re-raising to creating a trace object. I suppose this would
just need to be bounded by the flag-check. Unless someone has a suggestion
of making graceful exit possible - perhaps, in response to `Ctrl+C`, asking
the user if they want to terminate or drop to debugger?
…On 5 April 2018 at 03:51, Bruno Oliveira ***@***.***> wrote:
Thanks for the offer @brianmaissy <https://github.com/brianmaissy>, IMHO
this sounds useful, I have needed something like this a few times in the
past as well. I think adding a new flag seems harmless, but I wonder how
the implementation will look like. I would say give it a go and we can
discuss this over the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC_zrWrEdNpXYzV09e5lP9xA0MQDEas5ks5tlXihgaJpZM4SmoQA>
.
|
|
I think it should be possible to know if |
|
currently i believe the debugging plugin explicitly ignores interrupts to ctrl*c - in order to enable exiting the test run via a interrupt |
|
Yes, I wrote that in the top post. It's not at the debugging plugin level,
it's the whole error-handling mechanism, which doesn't wrap
`KeyboardInterrupt`-s but re-raises them instead.
AFAIK, pdb ignores `Ctrl+C`, as is to be expected by a shell. I don't know
if there's a way to change that behaviour - or if this is wanted, as people
expect `Ctrl+C` not to exit their pdb session.
…On 5 April 2018 at 13:23, Ronny Pfannschmidt ***@***.***> wrote:
currently i believe the debugging plugin explicitly ignores interrupts to
ctrl*c - in order to enable exiting the test run via a interrupt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC_zrYJezpL0Dj4y7MIJyzuECjVJgrCdks5tlf6ggaJpZM4SmoQA>
.
|
True. Ctrl-C results in Maybe pytest wrapping could then handle btw: with pdbpp you have But altogether with the new option you would basically only have to replace |
|
The current behavior of KeyboardInterrupt after dropping to pdb is to exit the test session, so I would be inclined to preserve that. It has the added benefit that if you pressed control-C with the intention of stopping the test session and then got a pdb the second control-C will indeed quit. So I'll go ahead an implement the "naive" approach? I thought to call the option |
Agreed.
I like that.
Contrary to what I said in #3299 (comment), perhaps we can avoid adding a new option and let |
|
Hmm interesting, I think I like that. |
|
Fixed in #3436, thanks @brianmaissy! |
This PR updates [pytest](https://pypi.org/project/pytest) from **3.5.1** to **3.6.3**. <details> <summary>Changelog</summary> ### 3.6.2 ``` ========================= Bug Fixes --------- - Fix regression in ``Node.add_marker`` by extracting the mark object of a ``MarkDecorator``. (`3555 <https://github.com/pytest-dev/pytest/issues/3555>`_) - Warnings without ``location`` were reported as ``None``. This is corrected to now report ``<undetermined location>``. (`3563 <https://github.com/pytest-dev/pytest/issues/3563>`_) - Continue to call finalizers in the stack when a finalizer in a former scope raises an exception. (`3569 <https://github.com/pytest-dev/pytest/issues/3569>`_) - Fix encoding error with `print` statements in doctests (`3583 <https://github.com/pytest-dev/pytest/issues/3583>`_) Improved Documentation ---------------------- - Add documentation for the ``--strict`` flag. (`3549 <https://github.com/pytest-dev/pytest/issues/3549>`_) Trivial/Internal Changes ------------------------ - Update old quotation style to parens in fixture.rst documentation. (`3525 <https://github.com/pytest-dev/pytest/issues/3525>`_) - Improve display of hint about ``--fulltrace`` with ``KeyboardInterrupt``. (`3545 <https://github.com/pytest-dev/pytest/issues/3545>`_) - pytest's testsuite is no longer runnable through ``python setup.py test`` -- instead invoke ``pytest`` or ``tox`` directly. (`3552 <https://github.com/pytest-dev/pytest/issues/3552>`_) - Fix typo in documentation (`3567 <https://github.com/pytest-dev/pytest/issues/3567>`_) ``` ### 3.6.1 ``` ========================= Bug Fixes --------- - Fixed a bug where stdout and stderr were logged twice by junitxml when a test was marked xfail. (`3491 <https://github.com/pytest-dev/pytest/issues/3491>`_) - Fix ``usefixtures`` mark applyed to unittest tests by correctly instantiating ``FixtureInfo``. (`3498 <https://github.com/pytest-dev/pytest/issues/3498>`_) - Fix assertion rewriter compatibility with libraries that monkey patch ``file`` objects. (`3503 <https://github.com/pytest-dev/pytest/issues/3503>`_) Improved Documentation ---------------------- - Added a section on how to use fixtures as factories to the fixture documentation. (`3461 <https://github.com/pytest-dev/pytest/issues/3461>`_) Trivial/Internal Changes ------------------------ - Enable caching for pip/pre-commit in order to reduce build time on travis/appveyor. (`3502 <https://github.com/pytest-dev/pytest/issues/3502>`_) - Switch pytest to the src/ layout as we already suggested it for good practice - now we implement it as well. (`3513 <https://github.com/pytest-dev/pytest/issues/3513>`_) - Fix if in tests to support 3.7.0b5, where a docstring handling in AST got reverted. (`3530 <https://github.com/pytest-dev/pytest/issues/3530>`_) - Remove some python2.5 compatibility code. (`3529 <https://github.com/pytest-dev/pytest/issues/3529>`_) ``` ### 3.6.0 ``` ========================= Features -------- - Revamp the internals of the ``pytest.mark`` implementation with correct per node handling which fixes a number of long standing bugs caused by the old design. This introduces new ``Node.iter_markers(name)`` and ``Node.get_closest_mark(name)`` APIs. Users are **strongly encouraged** to read the `reasons for the revamp in the docs <https://docs.pytest.org/en/latest/mark.htmlmarker-revamp-and-iteration>`_, or jump over to details about `updating existing code to use the new APIs <https://docs.pytest.org/en/latest/mark.htmlupdating-code>`_. (`3317 <https://github.com/pytest-dev/pytest/issues/3317>`_) - Now when ``pytest.fixture`` is applied more than once to the same function a ``ValueError`` is raised. This buggy behavior would cause surprising problems and if was working for a test suite it was mostly by accident. (`2334 <https://github.com/pytest-dev/pytest/issues/2334>`_) - Support for Python 3.7's builtin ``breakpoint()`` method, see `Using the builtin breakpoint function <https://docs.pytest.org/en/latest/usage.htmlbreakpoint-builtin>`_ for details. (`3180 <https://github.com/pytest-dev/pytest/issues/3180>`_) - ``monkeypatch`` now supports a ``context()`` function which acts as a context manager which undoes all patching done within the ``with`` block. (`3290 <https://github.com/pytest-dev/pytest/issues/3290>`_) - The ``--pdb`` option now causes KeyboardInterrupt to enter the debugger, instead of stopping the test session. On python 2.7, hitting CTRL+C again exits the debugger. On python 3.2 and higher, use CTRL+D. (`3299 <https://github.com/pytest-dev/pytest/issues/3299>`_) - pytest not longer changes the log level of the root logger when the ``log-level`` parameter has greater numeric value than that of the level of the root logger, which makes it play better with custom logging configuration in user code. (`3307 <https://github.com/pytest-dev/pytest/issues/3307>`_) Bug Fixes --------- - A rare race-condition which might result in corrupted ``.pyc`` files on Windows has been hopefully solved. (`3008 <https://github.com/pytest-dev/pytest/issues/3008>`_) - Also use iter_marker for discovering the marks applying for marker expressions from the cli to avoid the bad data from the legacy mark storage. (`3441 <https://github.com/pytest-dev/pytest/issues/3441>`_) - When showing diffs of failed assertions where the contents contain only whitespace, escape them using ``repr()`` first to make it easy to spot the differences. (`3443 <https://github.com/pytest-dev/pytest/issues/3443>`_) Improved Documentation ---------------------- - Change documentation copyright year to a range which auto-updates itself each time it is published. (`3303 <https://github.com/pytest-dev/pytest/issues/3303>`_) Trivial/Internal Changes ------------------------ - ``pytest`` now depends on the `python-atomicwrites <https://github.com/untitaker/python-atomicwrites>`_ library. (`3008 <https://github.com/pytest-dev/pytest/issues/3008>`_) - Update all pypi.python.org URLs to pypi.org. (`3431 <https://github.com/pytest-dev/pytest/issues/3431>`_) - Detect `pytest_` prefixed hooks using the internal plugin manager since ``pluggy`` is deprecating the ``implprefix`` argument to ``PluginManager``. (`3487 <https://github.com/pytest-dev/pytest/issues/3487>`_) - Import ``Mapping`` and ``Sequence`` from ``_pytest.compat`` instead of directly from ``collections`` in ``python_api.py::approx``. Add ``Mapping`` to ``_pytest.compat``, import it from ``collections`` on python 2, but from ``collections.abc`` on Python 3 to avoid a ``DeprecationWarning`` on Python 3.7 or newer. (`3497 <https://github.com/pytest-dev/pytest/issues/3497>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Repo: https://github.com/pytest-dev/pytest/issues - Homepage: http://pytest.org </details>
When debugging infinite-loop issues, it can sometimes be useful to enable dropping to debugger upon Ctrl+C. Currently
--pdbonly catches other exceptions,KeyboardInterruptis specifically ignored (runner.py:193,CallInfo.__init__). It would be nice to have a switch that makes it swallowKeyboardInterrupt-s as well instead. It would of course make it harder to quit (although a few consecutive Ctrl+C's usually due the trick), but it's a reasonable price to pay for those cases.The text was updated successfully, but these errors were encountered: