Using atomicwrites on Unix causes slowdown via fsync on the dir #6147
Comments
blueyed
added a commit
to blueyed/pytest
that referenced
this issue
Nov 7, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this issue
Nov 7, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this issue
Nov 7, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this issue
Nov 7, 2019
blueyed
added a commit
to blueyed/pytest
that referenced
this issue
Nov 7, 2019
iarspider
added a commit
to iarspider/spack
that referenced
this issue
Jun 3, 2020
Dropping atomicwrites dependency: pytest-dev/pytest#6147
adamjstewart
pushed a commit
to spack/spack
that referenced
this issue
Jun 4, 2020
Dropping atomicwrites dependency: pytest-dev/pytest#6147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In aa95a42 (via #3390) atomicwrites was added to fix an issue on Windows (to fix #3008).
It does not appear to have been necessary for non-Windows systems, and is actually causing a slowdown there (
pytest --collect-only: 5s => 8s on pytest's repo, with cleaned.pycfiles of course).The problem is that it calls
fsyncon the dir, which is not really necessary (untitaker/python-atomicwrites#17 (comment)).I think we should revert / change this to only use atomicwrites on Windows.
The text was updated successfully, but these errors were encountered: