Issue 1619 conftest assert rewrite #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.session = session | ||
|
|
||
| def set_config(self, config): |
There was a problem hiding this comment.
Should we change this to take config in the constructor?
| @@ -154,7 +164,8 @@ def _load_modules(mode): | |||
| from _pytest.assertion import rewrite # noqa | |||
|
|
|||
|
|
|||
| def warn_about_missing_assertion(mode): | |||
| def warn_about_missing_assertion(mode, pluginmanager): | |||
| print('got here') | |||
There was a problem hiding this comment.
I think this shouldn't be here?
…test-assert-rewrite
|
Tested it on my windows laptop since AppVeyor is stuck (py27,py35,linting). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now makes rewrites assertions in
conftest.pyfiles so they can benefit from assertion rewriting.Fixes #1619
cc @flub @sober7