Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling Fix #2847

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Spelling Fix #2847

merged 1 commit into from
Oct 18, 2017

Conversation

meawoppl
Copy link
Contributor

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.235% when pulling 11b391f on meawoppl:patch-1 into 3676da5 on pytest-dev:master.

@meawoppl
Copy link
Contributor Author

I can't own the testing falilure on that one. Do need to do any of the stuff in the PR template for a change this small? LMK and thanks.

@The-Compiler
Copy link
Member

I agree the failing tests aren't your fault, see #2843.

This is fine without a changelog or anything. Thanks!

@The-Compiler The-Compiler merged commit 2d08005 into pytest-dev:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants