Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: try to import --pdbcls in pytest_configure only #5041

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Apr 3, 2019

Fixes #5039.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #5041 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5041      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.03%     
==========================================
  Files         114      114              
  Lines       25757    25768      +11     
  Branches     2548     2548              
==========================================
+ Hits        24735    24754      +19     
+ Misses        711      704       -7     
+ Partials      311      310       -1
Impacted Files Coverage Δ
src/_pytest/debugging.py 88.64% <100%> (+0.31%) ⬆️
testing/test_pdb.py 99.19% <100%> (ø) ⬆️
testing/acceptance_test.py 98.03% <0%> (+0.39%) ⬆️
src/_pytest/doctest.py 96.41% <0%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46df1d5...757ada2. Read the comment docs.

@JBKahn
Copy link

JBKahn commented Apr 3, 2019

Thanks for getting on this 😀

@blueyed
Copy link
Contributor Author

blueyed commented Apr 3, 2019

@JBKahn
Sure, I always like to fix regression I've caused.. ;)

Can you review / test it, please?

@nicoddemus nicoddemus merged commit 973301b into pytest-dev:master Apr 3, 2019
@nicoddemus
Copy link
Member

Can you review / test it, please?

Oh sorry, I might have merged this too soon. 😬

@blueyed blueyed deleted the fix-pdbcls-regression branch April 3, 2019 22:36
@blueyed
Copy link
Contributor Author

blueyed commented Apr 3, 2019

@nicoddemus
No worries, I've added tests.. :)

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants