Handle xfail(strict=True) properly in --step-wise mode #5555
Conversation
asottile
added
the
needs backport
Codecov Report
@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
- Coverage 96.11% 96.09% -0.03%
==========================================
Files 117 117
Lines 25701 25713 +12
Branches 2493 2493
==========================================
+ Hits 24702 24708 +6
- Misses 695 701 +6
Partials 304 304
Continue to review full report at Codecov.
|
|
|
||
| # because we are writing to the same file, mtime might not be affected enough to | ||
| # invalidate the cache, making this next run flaky | ||
| testdir.tmpdir.join("__pycache__").remove() |
There was a problem hiding this comment.
argh!
Should we remove all __pycache__ directories from testdir.tmpdir before each testdir.runpytest call?
There was a problem hiding this comment.
ufff that's pretty unfortunate. Probably not though, the assert rewrite tests I think need that
Another idea would be to use utime to force the issue in another way
There was a problem hiding this comment.
Well in that case it doesn't really matter, so let's stick with just removing the __pycache__ for now.
|
I'll handle the backport 👍 |
Handle xfail(strict=True) properly in --step-wise mode
nicoddemus
added
backported
and removed
needs backport
|
grats on quads |
|
🎉 |
[4.6] Handle xfail(strict=True) properly in --step-wise mode (#5555)
| @@ -72,7 +72,7 @@ def pytest_collection_modifyitems(self, session, config, items): | |||
|
|
|||
| def pytest_runtest_logreport(self, report): | |||
| # Skip this hook if plugin is not active or the test is xfailed. | |||
Fix comment in stepwise (follow up to #5555) [skip ci]
…est-dev#5560) Fix comment in stepwise (follow up to pytest-dev#5555) [skip ci]
Fix #5547