Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate xunit2 files against the schema #5605

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

nicoddemus
Copy link
Member

Fix #5095

@pytest-dev pytest-dev deleted a comment from codecov bot Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #5605 into features will decrease coverage by 39.98%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           features    #5605       +/-   ##
=============================================
- Coverage     96.13%   56.15%   -39.99%     
=============================================
  Files           117       56       -61     
  Lines         25884    10915    -14969     
  Branches       2496     2037      -459     
=============================================
- Hits          24883     6129    -18754     
- Misses          694     4108     +3414     
- Partials        307      678      +371
Impacted Files Coverage Δ
src/_pytest/helpconfig.py 23.96% <0%> (-73.56%) ⬇️
src/_pytest/unittest.py 24.21% <0%> (-71.06%) ⬇️
src/_pytest/junitxml.py 25.44% <0%> (-70.42%) ⬇️
src/_pytest/mark/legacy.py 29.16% <0%> (-68.75%) ⬇️
src/_pytest/pastebin.py 19.29% <0%> (-68.43%) ⬇️
src/_pytest/debugging.py 21.98% <0%> (-68.07%) ⬇️
src/_pytest/setuponly.py 29.78% <0%> (-65.96%) ⬇️
src/_pytest/mark/evaluate.py 32.22% <0%> (-64.45%) ⬇️
src/_pytest/resultlog.py 23.88% <0%> (-62.69%) ⬇️
src/_pytest/skipping.py 34.37% <0%> (-61.46%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fab2b...ba72b48. Read the comment docs.

setup.py Outdated Show resolved Hide resolved
@nicoddemus nicoddemus force-pushed the xml-validation-5095 branch 3 times, most recently from c191caf to 57aa3ac Compare August 5, 2019 13:48
@nicoddemus
Copy link
Member Author

Updated.

Any reviewers? From my POV after this PR gets merged we can release 5.1.

@nicoddemus nicoddemus added this to the 5.1 milestone Aug 7, 2019
testing/test_junitxml.py Outdated Show resolved Hide resolved
testing/test_junitxml.py Show resolved Hide resolved
@nicoddemus nicoddemus requested a review from blueyed August 9, 2019 11:54
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

@nicoddemus nicoddemus force-pushed the xml-validation-5095 branch from 557827b to 881081f Compare August 9, 2019 13:53
nicoddemus and others added 2 commits August 9, 2019 10:55
@nicoddemus nicoddemus force-pushed the xml-validation-5095 branch from 881081f to ba72b48 Compare August 9, 2019 13:55
@nicoddemus
Copy link
Member Author

Rebased

@nicoddemus nicoddemus merged commit 65e6038 into pytest-dev:features Aug 9, 2019
@nicoddemus nicoddemus deleted the xml-validation-5095 branch August 9, 2019 15:34
@FRidh
Copy link

FRidh commented Aug 17, 2019

Would it be possible to skip tests/files that require xmlschema when it is not present in the environment? The reason I am asking is because pytest is a test dependency of xmlschema.
This is already done for pexpect and xdist.

In Nixpkgs that means we now have to disable tests of xmlschema because we need to build pytest first. Clearly we have to improve our situation of circular test dependencies here (there is also elementpath to consider), however, that is not trivial. For now we will disable these tests. when running the pytest suite.

@nicoddemus
Copy link
Member Author

@FRidh sure, I don't see any harm on doing so. Would be glad to review/merge a PR in that direction. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants