-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add datadog script, update claim event fields and subscriber #258
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -174,6 +174,8 @@ pub mod token_dispenser { | |||
claim_amount: claim_info.amount, | |||
claimant: *ctx.accounts.claimant.key, | |||
leaf_buffer: leaf_vector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guibescos do you think the leaf_buffer
is still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't it be useful to check double spends?
* DD_SITE="datadoghq.com" DD_API_KEY="<DD_API_KEY>" ts-node ./scripts/datadog.ts | ||
*/ | ||
|
||
import { client, v1 } from '@datadog/datadog-api-client' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmm I thought we where just gonna log instead of sending to datadog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah while events are nice I think they can slow us down. I think we can iterate faster with logs and then we can worry about parsing them and alerts later.
|
||
const errorTxnSigChunks = chunkArray(errorTxnSigs, this.chunkSize) | ||
|
||
const errorTxns = (await this.fetchTxns(errorTxnSigChunks)).map((txn) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it useful to fetch the transactions with errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these would be failed txns. if we see a large influx of failed txns someone could be attempting to exploit something or there may be some other issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty, gonna approve to unblock. Not sure about sending an event with each transactions, maybe you should look to aggregate information before sending events.
Summary
ecosystem
&address
toClaimEvent