feat: add aggregation key & double claim check #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Nov 15, 2023
| const entryGen = claimInfoMap.entries() | ||
| let entry = entryGen.next() | ||
| const doubleClaimEntries: Array<[string, Set<FormattedTxnEventInfo>]> = [] | ||
| while (!entry.done) { |
There was a problem hiding this comment.
This feels a bit dirty, why not for let entry of claimInfoMap
guibescos
reviewed
Nov 15, 2023
| function createDoubleClaimEventRequest( | ||
| formattedTxnEvents: FormattedTxnEventInfo[] | ||
| ): v1.EventsApiCreateEventRequest[] { | ||
| const claimInfoMap = new Map<string, Set<FormattedTxnEventInfo>>() |
There was a problem hiding this comment.
You don't need a set here, it's enough to count so a Map<string, number> is enough
There was a problem hiding this comment.
i have a set so i can capture the txn info in the datadog event. it'll be easier to investigate if this actually does get triggered
guibescos
reviewed
Nov 15, 2023
guibescos
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.