Integrate rich-argparse #1356
Merged
Integrate rich-argparse #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmvanbrunt
requested review from
tleonhardt,
kotfu and
anselor
as code owners
kmvanbrunt
force-pushed
the
rich-argparse
branch
from
3ec599a
to
4328960
Compare
kmvanbrunt
force-pushed
the
rich-argparse
branch
from
4328960
to
093ea9e
Compare
tleonhardt
approved these changes
Nov 1, 2024
|
|
||
| edit_parser.epilog = edit_parser.create_text_group( | ||
| "Note", | ||
| Markdown("To set a new editor, run: `set editor <program>`"), |
There was a problem hiding this comment.
Being able to use Markdown is really cool.
|
I'll have to experiment with how this looks and such, but tentatively I think it is really cool and think we might want to put out an intermediate release before 3.0.0, e.g. 2.6.0, since from a quick look this doesn't really seem to break backwards compatibility in any major way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
rich-argparsetocmd2.One big change is that
Cmd2ArgumentParserno longer defaults to using a raw help text formatter. Since we can use Rich renderables in descriptions and epilogs, I was able to get the desired paragraph separation with rich tables.Only the history command needs a raw help text formatter now because of how we print the help for
arg.Since an argument's help text can't be a Rich renderable we have to include
\ncharacters and only raw help text formatters preserve newlines.This change is for
cmd2 3.0.0.