Fixed ZeroDivisionError in async_alert() when shutil.get_terminal_size().columns returned 0. #1374
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleonhardt
previously approved these changes
Nov 6, 2024
cmd2/cmd2.py
Outdated
| @@ -5335,9 +5335,12 @@ def async_alert(self, alert_msg: str, new_prompt: Optional[str] = None) -> None: | |||
| if update_terminal: | |||
| import shutil | |||
|
|
|||
| # Prior to Python 3.11, this can return 0 for things like pseudo terminals. | |||
| terminal_columns = shutil.get_terminal_size().columns or 80 | |||
There was a problem hiding this comment.
Weird, I never considered the possibility of a zero-width terminal, but a guys for a pty that might be semi-reasonable.
nit: Consider defining a single constant for something like DEFAULT_TERMINAL_WIDTH = 80
kmvanbrunt
force-pushed
the
zero_terminal_width
branch
from
ffa777d
to
747f16b
Compare
…e().columns returned 0.
kmvanbrunt
force-pushed
the
zero_terminal_width
branch
from
747f16b
to
a0bed42
Compare
tleonhardt
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.