Add shutdown_delay on the start() function parameter #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change default if time_shutdown is not correct int or float - Accept string if is a digit
fix flake8 warning remplace shortcut `f` not stable on python3.6 by format
fix typo
|
how about it @ChrisKnott ? |
ChrisKnott
approved these changes
Oct 19, 2021
I think the syntax of this multi-line string was not correct
3 tasks
|
This pr has not been released,latest release is 0.14.0 at 2020,so |
|
@dstricks Chris and I never released this! 😱 Could be a good candidate for you to prepare a 0.15.0 release. You'll need to add entries to the changelog, bump the version number, ands prepare a version bump PR (similar to #382). If you want to put that up, I'm happy to approve it. After it's in you can tag the release from here: https://github.com/python-eel/Eel/releases/new and it should automatically get packaged up and released. |
|
@samuelhwilliams Sounds good. Will be the next thing I work on... |
Merged
|
v0.15.0 has been released and is available on PyPI.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timer configurable for Eel's shutdown detection mechanism, whereby when any websocket closes, it waits
shutdown_delayseconds (default 1 second), and then checks if there are now any websocket connections. If not, then Eel closes. In case the user has closed the browser and wants to exit the program.Try to fix #355 issues: Increase the value
shutdown_delayhigher to avoid stopping Eel.