Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added app mode support for micorsoft edge, IE mode for internet explorer and increase timeout for test run. #744

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

Meenapintu
Copy link
Contributor

Added MSIE mode to support device which does not have edge installed by default ( win <10).

Added support in edge to support edge mode or new window mode if app mode is not requested

tux test timeout updated as windows on GA was always failing with timeout.

@Meenapintu Meenapintu changed the title Added app mode support for micorsoft edge, IE mode for internet explorer and increase timeout for test run as it was failing with timeout. Added app mode support for micorsoft edge, IE mode for internet explorer and increase timeout for test run. Nov 14, 2024
@samuelhwilliams
Copy link
Collaborator

  180.01s setup    tests/integration/test_examples.py::test_01_hello_world
  2.01s setup    tests/integration/test_examples.py::test_02_callbacks
  1.97s setup    tests/integration/test_examples.py::test_06_jinja_templates
  1.95s setup    tests/integration/test_examples.py::test_10_custom_app
  1.89s setup    tests/integration/test_examples.py::test_04_file_access

I wonder what that one-off setup that Windows apparently needs to do is 🤔

Thanks for this update - nice to have the Windows test passing again, and the MSIE support has been requested for a long time, too 🙏

@samuelhwilliams samuelhwilliams merged commit 094d446 into python-eel:main Nov 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants