Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building universal wheels #78

Merged
merged 1 commit into from
Jun 11, 2015

Conversation

dhellmann
Copy link
Contributor

Remove the use of execfile() in setup.py so it can run under python 3.

Set the flag in setup.cfg to allow universal wheels.

Remove the use of execfile() in setup.py so it can run under python 3.

Set the flag in setup.cfg to allow universal wheels.
@dhellmann
Copy link
Contributor Author

Without this change in place, I see this error:

  $ python setup.py bdist_wheel
  Traceback (most recent call last):
    File "setup.py", line 5, in <module>
      execfile('happybase/_version.py')
  NameError: name 'execfile' is not defined

@wbolster
Copy link
Member

Thanks!

FYI, Happybase only supported Python 2 because the Thrift library it depends on lacked Python 3 support. It seems that is now a thing of the past.

@wbolster wbolster mentioned this pull request Jan 13, 2015
3 tasks
@dhellmann
Copy link
Contributor Author

I wasn't actually able to build wheels at all without the changes to setup.py. The "universal" flag was added as a "bonus".

@wbolster
Copy link
Member

I don't understand. Why would execfile fail? In Python 3 that function doesn't exist anymore, but in Python 2 it should be there, right?

@dhellmann
Copy link
Contributor Author

Ah, my default pip happens to be configured to point to python3, so if I run "pip wheel happybase" it fails.

@wbolster
Copy link
Member

Okay, I will merge this when I find time to get the other stuff required to release a version with Python 3 support done (#40).

wbolster added a commit that referenced this pull request Jun 11, 2015
Enable building universal wheels
@wbolster wbolster merged commit 9cbd718 into python-happybase:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants