Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation for "thousand" and fix singulars #97

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

aborruso
Copy link
Contributor

@aborruso aborruso commented Feb 4, 2023

I have added the thousand Italian string

@hugovk hugovk added the changelog: Added For new features label Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #97 (31b9ead) into main (1feba83) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files           9        9           
  Lines         743      743           
=======================================
  Hits          736      736           
  Misses          7        7           
Flag Coverage Δ
macos-latest 97.44% <ø> (-0.41%) ⬇️
ubuntu-latest 97.84% <ø> (ø)
windows-latest 95.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hugovk
Copy link
Member

hugovk commented Feb 4, 2023

Thanks! Are there different forms for singular and plural? If so, please put the singular first and plural second.

@hugovk hugovk changed the title The thousand Italian string Add Italian translation for "thousand" Feb 4, 2023
@aborruso
Copy link
Contributor Author

aborruso commented Feb 4, 2023

Thanks! Are there different forms for singular and plural? If so, please put the singular first and plural second.

I have seen that there are several errors on singulars. I correct them all

@aborruso
Copy link
Contributor Author

aborruso commented Feb 4, 2023

Thanks! Are there different forms for singular and plural? If so, please put the singular first and plural second.

Done, thank you

31b9ead

@hugovk hugovk changed the title Add Italian translation for "thousand" Add Italian translation for "thousand" and fix singulars Feb 4, 2023
@hugovk hugovk enabled auto-merge February 4, 2023 14:02
@hugovk hugovk disabled auto-merge February 4, 2023 14:03
@hugovk hugovk enabled auto-merge (squash) February 4, 2023 14:03
@hugovk
Copy link
Member

hugovk commented Feb 4, 2023

Grazie mille!

@hugovk hugovk merged commit 59705e1 into python-humanize:main Feb 4, 2023
@aborruso
Copy link
Contributor Author

aborruso commented Feb 4, 2023

Grazie mille!

how to use humanize and these two PR of mines? Do you will create a new release or do I must install if from git?

Thank you

@hugovk
Copy link
Member

hugovk commented Feb 4, 2023

I've just released them in 4.6.0. Thanks again!

@aborruso
Copy link
Contributor Author

aborruso commented Feb 4, 2023

I've just released them in 4.6.0. Thanks again!

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants