Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the Headers class is a Sequence #125

Merged
merged 1 commit into from
May 16, 2021
Merged

Clarify that the Headers class is a Sequence #125

merged 1 commit into from
May 16, 2021

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Dec 27, 2020

This is both in the docs (via the changelog) and by inheriting from
the Sequence ABC.

@pgjones pgjones mentioned this pull request Dec 27, 2020
Closed
bluetech
bluetech approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optionally, Sequence has an __iter__ mixin so you could remove the manual implementation if you want.

@pgjones
Clarify that the Headers class is a Sequence
a022a58 
This is both in the docs (via the changelog) and by inheriting from
the Sequence ABC. As the Sequence ABC has a __iter__ method another is
not required.
@pgjones pgjones merged commit 0f719f0 into python-hyper:master May 16, 2021
@pgjones pgjones deleted the sequence branch May 16, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgjones @bluetech