Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron workflow name #473

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

jrdnbradford
Copy link
Contributor

It looks like 845f8e5 changed cron.yaml to run weekly instead of daily, but the name of the workflow was left as daily. This just updates the name.

(Or perhaps the name should be something like scheduled-schema-update?)

@sirosen
Copy link
Member

sirosen commented Aug 5, 2024

Thanks for this; good catch!

Let's leave it with "weekly" for now. The idea I had when I named the prior one "daily" was that it would be the workflow for potentially multiple daily jobs. So, following that reasoning, this is a workflow for any weekly jobs. (I'm not super attached to this scheme, but I'd rather not change it unless there's a clear reason to do so.)

I'll look at that build failure after merging this. I'm guessing that py3.8 support is uneven across upstream libraries, and it leads to some weird situation.

@sirosen sirosen merged commit 8e0dbc1 into python-jsonschema:main Aug 5, 2024
21 of 23 checks passed
@jrdnbradford
Copy link
Contributor Author

Awesome, see my link in my accidental PR #474 re the mindeps issue.

@jrdnbradford jrdnbradford deleted the gha-name branch August 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants